Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added init function #965

Closed
wants to merge 3 commits into from
Closed

added init function #965

wants to merge 3 commits into from

Conversation

PlanetDestroyyer
Copy link
Contributor

@PlanetDestroyyer PlanetDestroyyer commented May 14, 2024 •
edited
Loading

Description

The changes made in this pull request should be briefly described.

Resolves: [Issue Number]

Checklist

Before submitting this pull request, kindly verify that the ensuing checkpoints have been reached.

  • Have you adhered to the repository's defined coding convention rules?
  • Have you updated the 'documentation.md' file with the method/function documentation?
  • Have you sent a message along with the result or response?
  • Have you used the try-catch technique?
  • Has the method/class been added to the documentation (md file)?

Screenshots

Uploading a screenshot illustrating the approach you developed for validation is required.

Additional Notes/Comments

Any additional remarks or suggestions concerning this pull request are welcome.

I certify that I have carried out the relevant checks and provided the requisite screenshot for validation by submitting this pull request.
I appreciate your contribution.

nikhil25803
nikhil25803 requested changes May 16, 2024
View reviewed changes
Copy link
Member

@nikhil25803 nikhil25803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove all the print statements
  • add docstring to the class and methods you have created.
  • you can check other modules like github and imdb to see how classes are formatted and structured.
  • also add your methods in documentation.md file

@nikhil25803
Copy link
Member

Also resolve the merge conflict @PlanetDestroyyer

@PlanetDestroyyer
Copy link
Contributor Author

Ok sir

@nikhil25803 nikhil25803 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil25803 nikhil25803 nikhil25803 requested changes

Assignees
No one assigned
Labels
under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlanetDestroyyer @nikhil25803